fix(telemetry): rename isClientApiError to isUserApiError and exclude 400#729
Merged
fix(telemetry): rename isClientApiError to isUserApiError and exclude 400#729
Conversation
… 400 400 Bad Request indicates a CLI bug (malformed API request the CLI should never send), not a user error. The previous isClientApiError treated all 4xx uniformly, which would silently swallow 400s if they escaped Stricli. Rename to isUserApiError for clarity and change the boundary from >= 400 to > 400, ensuring 400 Bad Request is captured as an exception while 401-499 continue to be recorded as span attributes only.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Upgrade
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1599 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.35% 95.33% -0.02%
==========================================
Files 234 234 —
Lines 34209 34207 -2
Branches 0 0 —
==========================================
+ Hits 32618 32608 -10
- Misses 1591 1599 +8
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isClientApiError→isUserApiErrorfor clarity>= 400to> 400, excluding 400 Bad RequestContext
The two capture sites (
exceptionWhileRunningCommandin app.ts andwithTelemetryin telemetry.ts) had inconsistent 400 handling. The primary site (app.ts) correctly captures 400s, but the secondary safety-net (withTelemetry) was silently swallowing them viaisClientApiError. This aligns both sites.